Expense - Reduce confirmation form scrolling - #96203
Conversation
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
This is @flaviadefaria's issue. |
|
@sobitneupane kindly bump. |
|
@emkhalid Could you please add screen recordings for all platforms? |
sobitneupane
left a comment
There was a problem hiding this comment.
Screenshots/Videos
Android: HybridApp
Screen.Recording.2026-07-21.at.08.25.11.mov
Android: mWeb Chrome
Screen.Recording.2026-07-21.at.08.30.05.mov
iOS: HybridApp
Screen.Recording.2026-07-21.at.08.36.31.mov
iOS: mWeb Safari
Screen.Recording.2026-07-21.at.08.37.49.mov
|
@shawnborton, could you please take a look at the recordings above? Thanks! |
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
I also don't hate how it looks, but |
This comment has been minimized.
This comment has been minimized.
|
@shawnborton @Expensify/design Done — I replaced the illustration with the standard 20×20 Light:
Dark:
Light high contrast:
Dark high contrast: [Image
I also added the standard hover background following Danny’s suggestion. Would you like us to keep it? 😊 hover.mp4 |
|
That's looking pretty good to me! Mind making the few little tweaks I called out in my comment above? (That I made moments before you posted your update 😂) I think it's just changing the gap to |
|
Agree with all of that Danny, thanks for laying it out! |
|
Thanks @dannymcclain @shawnborton! The gap is now 8px, and the receipt icon changes to the success color on hover. Please review the updated result below. hover+gap-fix.mov |
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Tested on mobile and web - feeling good to me! |
|
Nice, let's get this into final review please! |
|
Looking great! |
|
@sobitneupane Could you please take a look when you have a chance? Thanks! |
sobitneupane
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
iOS: HybridApp
|
🚧 inimaga has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/inimaga in version: 9.4.45-0 🚀
|
Help site review — no changes requiredI reviewed the changes in this PR against the help site articles under Why: This is a purely visual/density change to the expense confirmation form — it doesn't add, rename, or remove any documented feature, workflow, or label:
The receipt-related articles that mention adding a receipt use general phrasing that stays accurate after this change:
None of these describe the confirmation form's vertical spacing, the "To" header, or the empty-receipt layout, so they remain correct. @emkhalid, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR (Note: no help site PR was created because no documentation changes are needed for this UI density change. If you believe an article should be updated, let me know which one and what behavior to capture.) |
|
Deploy Blocker #97153 was identified to be related to this PR. |





















Explanation of Change
This PR reduces vertical space on the expense confirmation form:
ReceiptEmptyStateconsumers and preserves the scan flow's compact sizing.This follows the latest Expensify engineer clarification to leave the invoice flow unaffected by the "To" header removal.
Fixed Issues
$ #95564
PROPOSAL: #95564 (comment)
Tests
Offline tests
QA Steps
Same as Tests.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-native.mov
Android: mWeb Chrome
android-web.mov
iOS: Native
ios-native.mov
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
Expence:
Invoice: