Skip to content

Expense - Reduce confirmation form scrolling - #96203

Merged
inimaga merged 12 commits into
Expensify:mainfrom
emkhalid:fix/95564-reduce-expense-form-scrolling
Jul 26, 2026
Merged

Expense - Reduce confirmation form scrolling#96203
inimaga merged 12 commits into
Expensify:mainfrom
emkhalid:fix/95564-reduce-expense-form-scrolling

Conversation

@emkhalid

@emkhalid emkhalid commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

This PR reduces vertical space on the expense confirmation form:

  • Removes the redundant "To" header from non-invoice expense flows.
  • Preserves the "To" header for invoices, where it pairs with the "Send from" field.
  • Adds a compact 52px empty receipt state containing the receipt icon and the existing "Add receipt" label.
  • Uses the compact receipt state only on the confirmation form when no receipt is attached.
  • Keeps the existing receipt preview size after a receipt is attached.
  • Keeps the existing empty receipt layout for other ReceiptEmptyState consumers and preserves the scan flow's compact sizing.

This follows the latest Expensify engineer clarification to leave the invoice flow unaffected by the "To" header removal.

Fixed Issues

$ #95564
PROPOSAL: #95564 (comment)

Tests

  1. Sign in as an employee of a workspace with Category, required Tags, and Reimbursable enabled.
  2. Start creating a manual expense.
  3. Enter an amount, select the workspace recipient, and continue to Confirm details without adding a receipt.
  4. Verify the "To" header is not displayed.
  5. Verify the empty receipt state is a compact row containing the receipt icon and bold "Add receipt" text.
  6. Verify more expense fields, including Category, required Tags, and Reimbursable, are visible without scrolling.
  7. Tap Add receipt and attach a receipt.
  8. Verify the attached receipt uses the existing larger preview.
  9. Start creating an invoice and continue to its confirmation screen.
  10. Verify the invoice still displays the "To" header.
  • Verify that no errors appear in the JS console

Offline tests

  1. Open the workspace while online so its data is available locally.
  2. Disconnect from the network.
  3. Start creating a manual expense and continue to Confirm details without adding a receipt.
  4. Verify the "To" header is not displayed.
  5. Verify the compact receipt row displays the receipt icon and bold "Add receipt" text.
  6. Attach a locally available receipt.
  7. Verify the attached receipt uses the existing larger preview.

QA Steps

Same as Tests.

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android-native.mov
Android: mWeb Chrome
android-web.mov
iOS: Native
ios-native.mov
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari

Expence:

macos-fix

Invoice:

invoice

@emkhalid
emkhalid marked this pull request as ready for review July 15, 2026 18:36
@emkhalid
emkhalid requested review from a team as code owners July 15, 2026 18:36
@melvin-bot
melvin-bot Bot requested review from sobitneupane and removed request for a team July 15, 2026 18:36
@melvin-bot

melvin-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and removed request for a team July 15, 2026 18:37
Comment thread src/components/ReceiptEmptyState.tsx
Comment thread src/components/ReceiptEmptyState.tsx Outdated
Comment thread src/components/ReceiptEmptyState.tsx Outdated
@JmillsExpensify
JmillsExpensify requested review from flaviadefaria and removed request for JmillsExpensify July 17, 2026 09:21
@JmillsExpensify

Copy link
Copy Markdown
Contributor

This is @flaviadefaria's issue.

flaviadefaria
flaviadefaria previously approved these changes Jul 17, 2026

@flaviadefaria flaviadefaria left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emkhalid

Copy link
Copy Markdown
Contributor Author

@sobitneupane kindly bump.

@sobitneupane

Copy link
Copy Markdown
Contributor

@emkhalid Could you please add screen recordings for all platforms?

@sobitneupane sobitneupane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-07-21.at.08.25.11.mov
Android: mWeb Chrome
Screen.Recording.2026-07-21.at.08.30.05.mov
iOS: HybridApp
Screen.Recording.2026-07-21.at.08.36.31.mov
iOS: mWeb Safari
Screen.Recording.2026-07-21.at.08.37.49.mov
MacOS: Chrome / Safari Image Image
Screen.Recording.2026-07-21.at.08.14.51.mov

@sobitneupane

Copy link
Copy Markdown
Contributor

@shawnborton, could you please take a look at the recordings above? Thanks!

@shawnborton

Copy link
Copy Markdown
Contributor

@Expensify/design I will run test builds now, but quickly: should the border radius of this empty state by 8px instead of 16px? I think it was designed to be smaller, but I don't hate how this looks.
CleanShot 2026-07-21 at 09 10 25@2x

@github-actions

Copy link
Copy Markdown
Contributor

🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

@dannymcclain

Copy link
Copy Markdown
Contributor

I will run test builds now, but quickly: should the border radius of this empty state by 8px instead of 16px? I think it was designed to be smaller, but I don't hate how this looks.

I also don't hate how it looks, but 8px might make more sense to align it with the border radius of our inputs. This is feeling a bit more input-y now that it's small so I could see that looking nice.

@github-actions

This comment has been minimized.

@shawnborton

Copy link
Copy Markdown
Contributor

Yeah, okay let's do 8px for the border radius.

The receipt icon is borked - if you zoom in, notice how it's not lined up. Why do we have overlapping elements here and not just one svg? I can provide a new asset if that is easier, that would be my preference.
CleanShot 2026-07-21 at 10 26 15@2x

Also the gaps between the receipt empty state and the fields above/below are incorrect. Compare to Figma...
CleanShot 2026-07-21 at 10 27 11@2x

For your reference:

CleanShot.2026-07-21.at.10.28.06.mp4

@dannymcclain

Copy link
Copy Markdown
Contributor

Right onnnnn. This is what I would propose:
image

  • 20x20px icon
  • 8px gap between the icon and the text

Hover:

  • Background changes from highlight-bg to row-hover
  • Icon changes from icons to success

Does that sound good to you @Expensify/design ?

@emkhalid

Copy link
Copy Markdown
Contributor Author

@shawnborton @Expensify/design Done — I replaced the illustration with the standard 20×20 ReceiptPlus Expensicon. Here are the results in all four themes:

Light:

light

Dark:

dark

Light high contrast:

light-high

Dark high contrast: [Image

dark-high

I also added the standard hover background following Danny’s suggestion. Would you like us to keep it? 😊

hover.mp4

@dannymcclain

dannymcclain commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

That's looking pretty good to me! Mind making the few little tweaks I called out in my comment above? (That I made moments before you posted your update 😂)

I think it's just changing the gap to 8px and changing the icon color to success on hover.

@shawnborton

Copy link
Copy Markdown
Contributor

Agree with all of that Danny, thanks for laying it out!

@emkhalid

Copy link
Copy Markdown
Contributor Author

Thanks @dannymcclain @shawnborton! The gap is now 8px, and the receipt icon changes to the success color on hover. Please review the updated result below.

hover+gap-fix.mov

@github-actions

Copy link
Copy Markdown
Contributor

🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@shawnborton

Copy link
Copy Markdown
Contributor

Tested on mobile and web - feeling good to me!

@shawnborton

Copy link
Copy Markdown
Contributor

Last change: we can reduce the padding above the Add Receipt button:
CleanShot 2026-07-23 at 12 21 33@2x

I think we can actually just get rid of the margin-top: 12px here:
CleanShot 2026-07-23 at 12 22 21@2x

@emkhalid

Copy link
Copy Markdown
Contributor Author

I think we can actually just get rid of the margin-top: 12px here:

Thanks Shawn! I removed the extra 12px margin above Add receipt:

image

@shawnborton

Copy link
Copy Markdown
Contributor

Nice, let's get this into final review please!

@dubielzyk-expensify

dubielzyk-expensify commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Looking great!

@emkhalid

Copy link
Copy Markdown
Contributor Author

@sobitneupane Could you please take a look when you have a chance? Thanks!

@sobitneupane sobitneupane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp Image Image
Android: mWeb Chrome Image Image
iOS: HybridApp
iOS: mWeb Safari Image Image
MacOS: Chrome / Safari Image Image

@melvin-bot
melvin-bot Bot requested a review from inimaga July 24, 2026 17:21
@inimaga
inimaga merged commit e51e6af into Expensify:main Jul 26, 2026
36 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 inimaga has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/inimaga in version: 9.4.45-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site review — no changes required

I reviewed the changes in this PR against the help site articles under docs/articles, and no help site updates are required. I did not create a draft PR.

Why: This is a purely visual/density change to the expense confirmation form — it doesn't add, rename, or remove any documented feature, workflow, or label:

  • "To" header removal — Hides the "To" section header on non-invoice confirmation flows (kept for invoices, where it pairs with "Send from"). No help article documents this header.
  • Compact empty-receipt state — Renders a 52px row with the receipt icon + the existing Add receipt label when no receipt is attached on the confirmation form. The Add receipt copy is unchanged (it already exists via dropzone.addReceipt), and the full receipt preview/other consumers are untouched.
  • Spacing tweaks (mv3mb3/mt2) — Layout-only.

The receipt-related articles that mention adding a receipt use general phrasing that stays accurate after this change:

None of these describe the confirmation form's vertical spacing, the "To" header, or the empty-receipt layout, so they remain correct.


@emkhalid, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

(Note: no help site PR was created because no documentation changes are needed for this UI density change. If you believe an article should be updated, let me know which one and what behavior to capture.)

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #97153 was identified to be related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.